On Wed, Jul 08, 2015 at 11:43:50AM +0200, Nicolas Dichtel wrote: > Le 07/07/2015 19:56, Andy Gospodarek a écrit : > >This kernel patch exports the value of the new > >ignore_routes_with_linkdown via netconf. > > > >v2: changes to notify userspace via netlink when sysctl values change > >and proposed for 'net' since this could be considered a bugfix > Hmm, commit title contains net-next, not net. I went back and forth about where it should land.
Dave, any chance we might be able to add this to 'net' rather than saving it for 4.3? It isn't a bug-fix per se, but does help make this feature complete. > > > > >Signed-off-by: Andy Gospodarek <go...@cumulusnetworks.com> > >Suggested-by: Nicolas Dichtel <nicolas.dich...@6wind.com> > Acked-by: Nicolas Dichtel <nicolas.dich...@6wind.com> > > >--- > >I realize two of these changes result in lines >80 chars, but this is to > >keep the coding-style used by the surrounding code. > > > >There are multiple ways to resolve this, but one would be to shorten the > >defines used for this feature as "IGNORE_ROUTES_WITH_LINKDOWN" is a > >mouthful. I would propose dropping "_WITH_" from all the defines and > >have only "IGNORE_ROUTES_LINKDOWN" everywhere. Doing this now in 'net' > Yes. Or even shorter: IGNORE_NH_LINKDOWN? That might be a more appropriate name considering multipath/ecmp cases. > > >would be ideal before a release happens and it cannot be changed. > Yes. I'll cook up an update based on this patch and see what it looks like. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
