On Fri, Jun 26, 2015 at 9:21 PM, Sergei Shtylyov <sergei.shtyl...@cogentembedded.com> wrote: > Hello. > > On 6/26/2015 3:08 PM, Geert Uytterhoeven wrote: > >> If NO_DMA=y: > > >> ERROR: "dma_sync_single_for_cpu" >> [drivers/net/ethernet/via/via-rhine.ko] undefined! >> ERROR: "dma_set_mask" [drivers/net/ethernet/via/via-rhine.ko] >> undefined! >> ERROR: "dma_mapping_error" [drivers/net/ethernet/via/via-rhine.ko] >> undefined! >> ERROR: "dma_map_single" [drivers/net/ethernet/via/via-rhine.ko] >> undefined! >> ERROR: "dma_alloc_coherent" [drivers/net/ethernet/via/via-rhine.ko] >> undefined! >> ERROR: "dma_free_coherent" [drivers/net/ethernet/via/via-rhine.ko] >> undefined! >> ERROR: "dma_unmap_single" [drivers/net/ethernet/via/via-rhine.ko] >> undefined! >> ERROR: "dma_map_page" [drivers/net/ethernet/via/via-velocity.ko] >> undefined! >> ERROR: "dma_sync_single_for_cpu" >> [drivers/net/ethernet/via/via-velocity.ko] undefined! >> ERROR: "dma_free_coherent" [drivers/net/ethernet/via/via-velocity.ko] >> undefined! >> ERROR: "dma_unmap_single" [drivers/net/ethernet/via/via-velocity.ko] >> undefined! >> ERROR: "dma_map_single" [drivers/net/ethernet/via/via-velocity.ko] >> undefined! >> ERROR: "dma_alloc_coherent" >> [drivers/net/ethernet/via/via-velocity.ko] undefined! > > >> Before, the symbols depended implicitly on HAS_DMA through PCI or >> USE_OF. Add explicit dependencies on HAS_DMA to fix this. > > >> Fixes: commit b7d3282a245f4428 ("net: via/Kconfig: replace USE_OF with >> OF_???") > > > Fixes: b7d3282a245f ("net: via/Kconfig: replace USE_OF with OF_???") > >> Signed-off-by: Geert Uytterhoeven <ge...@linux-m68k.org> > > > WBR, Sergei >
Yes, I can confirm it. If HAS_DMA is not defined the build is broken. Your patch fixes the issue. Thanks, Antonio -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html