Thu, Jun 25, 2015 at 03:33:31PM CEST, da...@davemloft.net wrote: >From: Geert Uytterhoeven <ge...@linux-m68k.org> >Date: Thu, 25 Jun 2015 15:10:32 +0200 > >> net/core/flow_dissector.c: In function ‘__skb_flow_dissect’: >> net/core/flow_dissector.c:132: warning: ‘ip_proto’ may be used uninitialized >> in this function >> >> Signed-off-by: Geert Uytterhoeven <ge...@linux-m68k.org> >> --- >> This may be a false positive, but the state machine in >> __skb_flow_dissect() is a bit hard to follow. >> As I believe it is controlled by a packet received from the network, the >> only safe thing to do is to pre-initialize ip_proto. > >Actually I think this is a real bug, because for the ETH_P_MPLS_* cases I >cannot >see what will always set ip_proto before it gets used as an input.
I think that MPLS cases are ok. In this case, return is always hit. I believe this is false positive. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
