On Tue, Jun 23, 2015 at 02:30:40AM -0700, David Miller wrote:
> From: Andy Gospodarek <go...@cumulusnetworks.com>
> Date: Thu, 18 Jun 2015 11:22:10 -0400
>
> > - ((nh->nh_flags ^ onh->nh_flags) & ~RTNH_F_DEAD))
> > + ((nh->nh_flags ^ onh->nh_flags) & ~(RTNH_F_COMPARE_MASK)))
> > return -1;
>
> Excessive parenthesis, just plain "~RTNH_F_COMPARE_MASK" is sufficient.
>
> > + if (linkdown == fi->fib_nhs) {
> > + fi->fib_flags |= RTNH_F_LINKDOWN;
> > + }
>
> Single line basic blocks do not get enclosing curly braces.
Sorry...v6 coming soon.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
