On Wed, Jun 10, 2015 at 11:19:29PM -0400, Andy Gospodarek wrote: > On Wed, Jun 10, 2015 at 08:07:10PM -0700, Scott Feldman wrote: > > On Wed, Jun 10, 2015 at 7:37 PM, Andy Gospodarek > > <go...@cumulusnetworks.com> wrote: > > > > > There was also a request for switchdev support for this, but that will be > > > posted as a followup as switchdev does not currently handle dead > > > next-hops in a multi-path case and I felt that infra needed to be added > > > first. > > > > That's not true. switchdev_fib_ipv4_add() passes *fi and all of the > > nexthops for the route are hanging off of that, including the > > nh->flags where you're setting LINKDOWN. Multipath is not different > > than singlepath in that regard. Same API for both. > > The API is the same, but I did not see a path that would take a > multipath route and update the dead nexthops when an interface is taken > down with switchdev or rocker today. > > I could be wrong (and I will test again), but create a multipath route > with nexthops on swp1 and swp2 and then call 'ip link set swp1 down' and > let me know if you see rocker's ECMP routes get updated so only the > nexthop on swp2 will be used. >
Scott, as I stated before I have every intention of adding switchdev as well as ipv6 support and at this point I hope people know I'm good fot it. Since I'm already on v3 of the ipv4 support that is looking like a good idea. :) I'm sure you can empathize as you have organically grown the switchdev support in the kernel. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
