On Tue, Jun 09, 2015 at 10:23:57AM -0700, Nikolay Aleksandrov wrote:
> From: Nikolay Aleksandrov <ra...@blackwall.org>
>
> Since the addition of sysfs multicast router support if one set
> multicast_router to "2" more than once, then the port would be added to
> the hlist every time and could end up linking to itself and thus causing an
> endless loop for rlist walkers.
> So to reproduce just do:
> echo 2 > multicast_router; echo 2 > multicast_router;
> in a bridge port and let some igmp traffic flow, for me it hangs up
> in br_multicast_flood().
> Fix this by adding a check in br_multicast_add_router() if the port is
> already linked.
> The reason this didn't happen before the addition of multicast_router
> sysfs entries is because there's a !hlist_unhashed check that prevents
> it.
>
> Signed-off-by: Nikolay Aleksandrov <ra...@blackwall.org>
> Fixes: 0909e11758bd ("bridge: Add multicast_router sysfs entries")
Acked-by: Herbert Xu <herb...@gondor.apana.org.au>
--
Email: Herbert Xu <herb...@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
