On Wed, 2015-06-03 at 17:55 +0100, Julien Grall wrote: > rx->status is an int16_t, print it using %d rather than %u in order to > have a meaningful value when the field is negative. [] > diff --git a/drivers/net/xen-netfront.c b/drivers/net/xen-netfront.c [] > @@ -733,7 +733,7 @@ static int xennet_get_responses(struct netfront_queue > *queue, > if (unlikely(rx->status < 0 || > rx->offset + rx->status > PAGE_SIZE)) { > if (net_ratelimit()) > - dev_warn(dev, "rx->offset: %x, size: %u\n", > + dev_warn(dev, "rx->offset: %x, size: %d\n",
If you're going to do this, perhaps it'd be sensible to also change the %x to %#x or 0x%x so that people don't mistake offset without an [a-f] for decimal. > rx->offset, rx->status); -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html