On Thu, 2015-05-21 at 19:09 +0400, Ivan Mikhaylov wrote: > In ibm_emac.c in ethtool size of emac structure which passing through to > driver > is nailed down and not correlating with current emac_regs structure. > > Signed-off-by: Ivan Mikhaylov <i...@ru.ibm.com> [...]
This is not backward-compatible. It ought to be possible to mix and match old and new ethtool and driver, except for the EMAC4SYNC case which has been broken up until now. Using the new definition of struct emac_regs, I think the driver and ethtool need to agree that the MAC register dump sizes are: EMAC: offsetof(struct emac_regs, u1) EMAC4: offsetof(struct emac_regs, u1.emac4) + sizeof(p->u1.emac4) EMAC4SYNC: offsetof(struct emac_regs, u1.emac4sync) + sizeof(p->u1.emac4sync) Ben. -- Ben Hutchings Reality is just a crutch for people who can't handle science fiction.
signature.asc
Description: This is a digitally signed message part
