On Tue, May 26, 2015 at 05:36:34PM -0700, Eric Dumazet wrote: > > tldr: "TSO with max_segs==1" <is the same than> "no TSO/GSO"
Not really. They're not identical. For example, before your patch a packet greater than MSS with TSO disabled would call tcp_nagle_test, with your patch it will call tcp_tso_should_defer instead. Maybe this is OK but it is far from obvious. Cheers, -- Email: Herbert Xu <herb...@gondor.apana.org.au> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
