On 5/20/15 11:12 AM, Daniel Borkmann wrote:
Effectively, every in-tree classifier (rsvp is the only exception) is making use of call_rcu(). Moreover, moving this into every ->destroy() handler would also be unnecessary overhead, imho, as this is only relevant when we actually _unload_ a module.
+1 indeed unregister_tcf_proto_ops() is only called at module unload time. So there is no overhead from this rcu_barrier(). It's actually mandatory. All modules with rcu callbacks should do that. Acked-by: Alexei Starovoitov <a...@plumgrid.com> -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html