From: Florian Westphal <f...@strlen.de> Date: Fri, 15 May 2015 10:50:47 +0200
> This series prepares removal of tc_verd member from sk_buff. > > It simplifies tc state machinery to what is required to keep current > mirred/ifb combinations working. > > I tested a few scenarios, namely: > > 1 - htb based shaping on egress > 2 - netem attached to ifb with mirred redirect from ingress qdisc > 3 - mirred to different egress device > 4 - mirred to ifb egress device with qdiscs set up on ifb > to provide illusion of 'single' transmit interface for traffic shaping > > After this series tc_verd is only used by ifb to skip actions on egress. > > Part #2 of this series will remove tc_verd completely. > > motivation is two-fold: > 1) make states and state transitions more obvious > 2) provide a way to later reduce skb size by 8 bytes > (s/u16 mac_len/u8 mac_len/ would result in > two 2 byte and one 4 byte hole, i.e. 8 byte reduction with > minor reshuffling). It looks like there will be changes to this series. My only comment from my perspective is that, in patch #1, you should probably add a "TC_FROM_UNKNOWN = 0" to the enumeration and test/set using that instead of a magic constant. Thanks. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
