From: Joe Perches <j...@perches.com> Date: Mon, 04 May 2015 13:32:30 -0700
> On Mon, 2015-05-04 at 13:05 -0700, Joe Perches wrote: >> unsigned char * return values are sometimes awkward to work with. >> Changing the return to void * is sometimes clearer. >> >> The only uses of the return type is to do sets like >> *skb_puts(skb, 1) = char; >> >> Adding another function specifically for that purpose allows the return >> type to become void. > > Obviously, this shouldn't be applied as-is. > > It spans too many subsystems and can be done > more incrementally. > > Also, there are some missing conversions so > this won't compile properly (sorry 'bout that) I have no fundamental issues with this series once you fix up those issues. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html