From: Michael Trimarchi <mich...@amarulasolutions.com>
Date: Wed, 22 Apr 2015 01:13:47 +0200

> Hi
> 
> On Tue, Apr 21, 2015 at 05:35:40PM -0400, David Miller wrote:
>> From: Michael Trimarchi <mich...@amarulasolutions.com>
>> Date: Tue, 21 Apr 2015 13:16:13 +0200
>> 
>> > -                  udelay(data->delays[0]);
>>  ...
>> > +                  msleep(max(1U, data->delays[0] / 1000));
>> 
>> That looks very ugly with that max() expression in there.
>>
> 
> Is fine for you a DIV_ROUND_UP?

Not inside of these simple msleep() calls, no.

How about adjusting the values either in the datastructure or
in local variables instead?  That wasn't so hard to come up
with now, was it?
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to