From: Martin KaFai Lau <ka...@fb.com>
Date: Fri, 10 Apr 2015 18:54:07 -0700
> + if (!(rt6->rt6i_flags & RTF_CACHE) &&
> + (!(rt6->rt6i_flags & (RTF_NONEXTHOP | RTF_GATEWAY)) ||
> + !(rt6->dst.flags & DST_HOST))) {
These big convoluted tests are tiring to read over and over again.
At the very least, "(rt6->rt6i_flags & (RTF_NONEXTHOP | RTF_GATEWAY)"
deserves to be a descriptively named inline function.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
