On Wed, 2015-04-15 at 11:58 +0300, Or Gerlitz wrote: > On Wed, Apr 15, 2015 at 7:51 AM, Jeff Kirsher > <jeffrey.t.kirs...@intel.com> wrote: > > From: Anjali Singhai Jain <anjali.sing...@intel.com> > > > With this patch we can now add Flow director Sideband rules for a VF > from > > it's PF. Here is an example on how it can be done when VF id = 5 and > > queue = 2: > > > > "ethtool -N ethx flow-type udp4 src-ip x.x.x.x dst-ip y.y.y.y > src-port p1 dst-port p2 action 2 user-def 5" > > > > User-def specifies VF id and action specifies queue. > > Hi Jeff, > > We're too eager to have support for PF controlled ACL / over-ruling VF > traffic. > > I don't think the way to go here is just go an use the user-defined > "data" field of struct ethtool_flow_ext to represent a VF -- since VF > is well defined multiple vendor supported construct. At least in the > command line would be better to see "vf 5" and not "user-def 5" -- and > maybe also down into the user-kernel API somehow enhance the ethtool > flow related structures such that VF ID is specified?
Thanks for the feedback Or, I will work with Anajali and Jesse to get your suggestions implemented in follow-on patches.
signature.asc
Description: This is a digitally signed message part
