On Sun, Feb 10, 2008 at 01:10:07AM +0100, Ondrej Zary wrote:
> > > +typedef enum { EL3_ISA, EL3_PNP, EL3_MCA, EL3_EISA } el3_cardtype;
> > > +
> >
> > No typedef please (see checkpatch)
>
> Is there any standard way to solve this without a typedef? I added
> el3_dev_fill() function which fills that card type value according to a
> parameter passed to it. "int" could be used instead and "#define EL3_ISA
> 0", "#define EL3_PNP 1" - but I think that's ugly.
enum el3_cardtype {
EL3_ISA,
EL3_PNP,
EL3_MCA,
EL3_EISA,
};
> > > struct el3_private {
> > > struct net_device_stats stats;
> >
> > Use network device stats in net_device now
>
> OK, looks like the driver will need some more patches.
While I agree with Stephens comment that this driver should be using
the stats in net_device that's totally out of scope for this patch.
As you're the defacto maintainer of this driver now it would be nice
if you could submit another one for it.
> > > - struct net_device *next_dev;
> > > spinlock_t lock;
> > > /* skb send-queue */
> > > int head, size;
> > > struct sk_buff *queue[SKB_QUEUE_SIZE];
> >
> > What about sk_buff_head (linked list instead)?
>
> I don't know anything about this, maybe in next patch.
Yes, separate patch please.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
