On Thu, Feb 07, 2008 at 12:57:43AM +0100, Sven Wegener wrote: > The default synchronization interval of 1000 milliseconds is too high for a > heavily loaded director. Collecting the connection information from one second > and then sending it out in a burst will overflow the socket buffer and lead to > synchronization information being dropped. Make the interval controllable by a > sysctl variable so that users can tune it. We enforce a lower limit of 0 and > an > upper limit of 2000 ms on the interval. A too large interval can make the > synchronization buffer consume too much memory and will also delay the exit of > the kernel threads. > > Signed-off-by: Sven Wegener <[EMAIL PROTECTED]>
Hi Sven, I have no problems with the spirit of this patch, and the range checking seems good to me. Though I wonder if 2000 might not be an exessively low maximum. I can't think of a usage case off-hand, but I'm not sure I understand why a user shouldn't be able to set it to much (rediculously) higher values. In any case, thats not a big deal. Acked-by: Simon Horman <[EMAIL PROTECTED]> > --- > > Changes from the last version include the addition of the range enforcement. > Also place the definitions of the variables where all other ipvs sysctl > variables are. -- Horms -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
