Stephen Hemminger 写道: > On Fri, 25 Jan 2008 15:10:13 +0800 > shanwei <[EMAIL PROTECTED]> wrote: > >> hi all: >> >> In strategy_allowed_congestion_control of the 2.6.24 kernel, >> when sysctl_string return 1 on success,it should call >> tcp_set_allowed_congestion_control to set the allowed congestion >> control.But, it don't. >> the sysctl_string return 1 on success, otherwise return negative, >> never return 0.The patch fix the problem. >> >> Signed-off-by: Shan Wei <[EMAIL PROTECTED]> >> >> diff -Nuarp linux-2.6.24/net/ipv4/sysctl_net_ipv4.c >> linux-2.6.24-new/net/ipv4/sysctl_net_ipv4.c >> --- linux-2.6.24/net/ipv4/sysctl_net_ipv4.c 2008-01-25 06:58:37.000000000 >> +0800 >> +++ linux-2.6.24-new/net/ipv4/sysctl_net_ipv4.c 2008-01-25 >> 12:23:20.000000000 +0800 >> @@ -248,7 +248,7 @@ static int strategy_allowed_congestion_c >> >> tcp_get_available_congestion_control(tbl.data, tbl.maxlen); >> ret = sysctl_string(&tbl, name, nlen, oldval, oldlenp, newval, newlen); >> - if (ret == 0 && newval && newlen) >> + if (ret == 1 && newval && newlen) >> ret = tcp_set_allowed_congestion_control(tbl.data); >> kfree(tbl.data); >> >> > > Acked-by: Stephen Hemminger <[EMAIL PROTECTED]> > > This parallels previous fix by Sam Jansen. > > >From the link:http://marc.info/?l=linux-netdev&m=119551836927062&w=2, he only fix the sysctl_tcp_congestion_control function. In the latest kernel, the sysctl_string problem is present. Can this patch be applied?
-- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
