On Sat, 26 Jan 2008 10:58:58 +0200 "Alon Bar-Lev" <[EMAIL PROTECTED]> wrote:
> On 1/26/08, Alon Bar-Lev <[EMAIL PROTECTED]> wrote: > > On 1/26/08, Stephen Hemminger <[EMAIL PROTECTED]> wrote: > > > The issue is that iproute is just blindly sending the deletes and > > > not asking for acknowledgment status. Here is a trivial patch to iproute > > > to fix that, but the problem is that it means it will slow down bulk > > > removal. > > > > > > Maybe it should just check the first, or last delete to see if there are > > > errors? > > > > > > diff --git a/ip/iproute.c b/ip/iproute.c > > > index 7a885b0..b2ae879 100644 > > > --- a/ip/iproute.c > > > +++ b/ip/iproute.c > > > > This should also be applied into ip/ipaddress.c, ip/ipneigh.c > > Or even make one common function? > > > > I don't quite understand how "fast" is good if not complete... But > > anyway... I will be happy to see this fix in next version... Maybe add > > --fast argument? :) > > > > Alon. > > > > Pulled your latest git head. See some updates but not this one... > Just thought to report the following [new] build error: > > > gcc -Wl,-export-dynamic ip.o ipaddress.o iproute.o iprule.o rtm_map.o > iptunnel.o ip6tunnel.o tunnel.o ipneigh.o ipntable.o iplink.o > ipmaddr.o ipmonitor.o ipmroute.o ipprefix.o ipxfrm.o xfrm_state.o > xfrm_policy.o xfrm_monitor.o iplink_vlan.o link_veth.o > ../lib/libnetlink.a ../lib/libutil.a -lresolv -L../lib -lnetlink > -lutil -ldl -o ip > iptunnel.o: In function `parse_args': > iptunnel.c:(.text+0x2f6): undefined reference to `__constant_htons' > iptunnel.c:(.text+0x434): undefined reference to `__constant_htons' > iptunnel.c:(.text+0x4c1): undefined reference to `__constant_htons' > iptunnel.c:(.text+0x4da): undefined reference to `__constant_htons' > iptunnel.c:(.text+0x51c): undefined reference to `__constant_htons' > iptunnel.o:iptunnel.c:(.text+0x535): more undefined references to > `__constant_htons' follow > collect2: ld returned 1 exit status > make[1]: *** [ip] Error 1 What system are you building on. This is defined in linux/byteorder.h -- Stephen Hemminger <[EMAIL PROTECTED]> -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html