On Thu, Jan 10, 2008 at 12:50:46PM -0800, Jay Vosburgh wrote: > Herbert Xu <[EMAIL PROTECTED]> wrote: > > >On Thu, Jan 10, 2008 at 09:51:44AM -0500, Andy Gospodarek wrote: > >> > >> That wasn't the only purpose, Herbert. Making sure that calls to > >> dev_set_mac_address were called from process context was important at > >> the time of the coding as well since at least the tg3 driver took locks > >> that could not be taken reliably in soft-irq context. Michael Chan > >> fixed this here: > > > >Sure, but where do you call that function while holding the bond lock? > > If I recall correctly, the problem was that tg3, et al, did > things that might sleep, and bonding was calling from a timer context, > which couldn't sleep. It wasn't about the lock. >
Exactly, I was just about to post the same. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
