On Tue, 8 Jan 2008 16:27:39 -0800 Andrew Morton <[EMAIL PROTECTED]> wrote:
> On Wed, 09 Jan 2008 08:57:53 +0900 > FUJITA Tomonori <[EMAIL PROTECTED]> wrote: > > > Andrew, can you replace > > > > iommu-sg-add-iommu-helper-functions-for-the-free-area-management.patch > > > > with the updated patch: > > > > http://ozlabs.org/pipermail/linuxppc-dev/2007-December/048997.html > > > > For your convenience I've attached the updated patch too. > > <generates the incremental> Thanks for putting the fix to -mm. > > --- a/lib/iommu-helper.c~a > > +++ a/lib/iommu-helper.c > > @@ -8,15 +8,20 @@ > > static unsigned long find_next_zero_area(unsigned long *map, > > unsigned long size, > > unsigned long start, > > - unsigned int nr) > > + unsigned int nr, > > + unsigned long align_mask) > > { > > unsigned long index, end, i; > > again: > > index = find_next_zero_bit(map, size, start); > > + > > + /* Align allocation */ > > + index = (index + align_mask) & ~align_mask; > > The ALIGN() macro is the approved way of doing this. > > (I don't think ALIGN adds much value really, especially given that you've > commented what's going on, but I guess it does make reviewing and reading a > little easier). Would be better to use __ALIGN_MASK? I can find only one user who directly use __ALIGN_MASK. The POWER IOMMU calculates align_mask by itself so it's easier to pass align_mask as an argument. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
