On 04-01-2008 12:40, David Miller wrote: ... > That "tx_cleaned" thing clouds the logic in all of these driver's > poll routines. > > The one necessary precondition is that when work_done < budget > we exit polling and return a value less than budget. > > If the ->poll() returns a value less than budget, net_rx_action() > assumes that the device has been removed from the poll() list. > > /* Drivers must not modify the NAPI state if they > * consume the entire weight. In such cases this code > * still "owns" the NAPI instance and therefore can > * move the instance around on the list at-will. > */ > if (unlikely(work == weight)) > list_move_tail(&n->poll_list, list); >
Probably it's because of this clouded logic, but IMHO: "Drivers must not modify the NAPI state if..." doesn't imply: drivers must modify the NAPI state otherwise. (But it seems I must have missed the real reason for this quote here.) Regards, Jarek P. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
