On 2008.01.04 23:26:33 +0100, Björn Steinbrink wrote: > For cards that initially have the MAC address stored in reverse order, > the forcedeth driver uses a flag to signal whether the address was > already corrected, so that it is not reversed again on a subsequent > probe. > > Unfortunately this flag, which is stored in a register of the card, > seems to get lost during suspend, resulting in the MAC address being > reversed again. To fix that, the MAC address needs to be written back in > reversed order before we suspend and the flag needs to be reset. > > The flag is still required because at least kexec will never write back > the reversed address and thus needs to know what state the card is in. > > Signed-off-by: Björn Steinbrink <[EMAIL PROTECTED]> > --- > On 2008.01.04 15:08:42 +0100, Richard Jonsson wrote: > > Björn Steinbrink skrev: > >> Richard, could you give this a spin? And then we'd likely need someone > >> to test that with kexec... > > > > The patch you sent does the trick, works fine now, thanks! > > I cannot test this with kexec as I barely know what it is, I'll leave that > > to someone else. > > Thanks. > > Ayaz, you originally wrote the kexec fix (IIRC), was my analysis of the > problem correct? If so, I'm quite sure that the patch DTRT. Still it > should be tested for the rmmod+modprobe and the kexec case. I'll try to > get my box free for some testing, but that's unlikely in the next few > days. Plus, I've never used kexec myself either. So I'd be grateful if > someone else would step up.
Found a few minutes to test, but kexec would just hang for me. So I'm unable to test that atm. :-( Björn -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
