On Wednesday, January 02, 2008 16:56, Randy Dunlap wrote: > You could (should) make <ifnum> be unsigned int and then use > module_param(ifnum, uint, 0); and then ... > > then this block is mostly useless since ifnum cannot be < 0. > And how could it ever be > INT_MAX (when ifnum was an int)? > > If <ifnum> is unsigned int but you want to limit it to INT_MAX, > then half of this if-test would be OK. >
Thanks, that makes sense. I simply copied some of the max_bonds code which uses a signed int. I suppose that could be changed as well. I will post back a new patch. Jari -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
