Al Viro <[EMAIL PROTECTED]> :
[...]
> > Can we avoid using cpu_to_leXY here for consistency sake within the driver
> > (and among different drivers as well) ?
>
> ???
I admit that it is a bit late for the Xmas wishlist. Compare it with:
@@ -1409,31 +1409,33 @@ static int velocity_rx_srv(struct velocity_info *vptr,
int status)
do {
struct rx_desc *rd = vptr->rd_ring + rd_curr;
+ u16 rsr;
[...]
+ rsr = le16_to_cpu(rd->rdesc0.RSR);
[...]
- if (rd->rdesc0.RSR & RSR_CRC)
+ if (rsr & RSR_CRC)
^^^^^^^ this one is #define RSR_CRC 0x0002
-> some descriptor bits are now declared with an explicit endianness
while others are not (whence "u16 rsr" where "__le16 rsr" whould
have fit). Both are fine but it would not hurt to stick with one
convention in a given driver.
--
Ueimor
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
