On Dec 14, 2007 11:10 PM, Herbert Xu <[EMAIL PROTECTED]> wrote: > On Fri, Dec 14, 2007 at 05:47:22PM -0500, Andy Gospodarek wrote: > > > > I'm guessing if we go back to using a write-lock for bond->lock this > > will go back to working again, but I'm not totally convinced since there > > are plenty of places where we used a read-lock with it. > > Sorry I forgot to cc you earlier Andy. > > But to fix this you need make sure that all read locks on bond->lock > in process context disable BH. This is because at least one write > lock can be taken from BH context.
I agree with you completely, Herbet, which is why I was surprised that my first apparently did not resolve the issue. I felt it should have.... > You don't need to turn the read locks into write locks however. > > This is also something that we can undo once the set_multicast > interface has been fixed to not take the tx lock. > > Cheers, > -- > Visit Openswan at http://www.openswan.org/ > Email: Herbert Xu ~{PmV>HI~} <[EMAIL PROTECTED]> > Home Page: http://gondor.apana.org.au/~herbert/ > PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt > -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
