Ed, You mention that the phy will become 100Mbit half duplex, but during nv_close, the phy setting is not modified. This might be a separate issue.
Ayaz -----Original Message----- From: Andrew Morton [mailto:[EMAIL PROTECTED] Sent: Thursday, December 13, 2007 5:07 PM To: Ed Swierk Cc: Ayaz Abdulla; [EMAIL PROTECTED]; netdev@vger.kernel.org Subject: Re: [patch 02/10] forcedeth: power down phy when interface is down On Thu, 13 Dec 2007 16:53:58 -0800 "Ed Swierk" <[EMAIL PROTECTED]> wrote: > On 12/13/07, Andrew Morton <[EMAIL PROTECTED]> wrote: > > Does this patch actually fix any observeable problem? > > Without the patch, ifconfig down leaves the physical link up, which > confuses datacenter users who expect the link lights both on the NIC > and the switch to go out when they bring an interface down. > > Furthermore, even though the phy is powered on, autonegotiation stops > working, so a normally gigabit link might suddenly become 100 Mbit > half-duplex when the interface goes down, and become gigabit when it > comes up again. > OK, thanks, I added that text to the changelog along with Ayaz's objection and shall continue to bug people with it until we have a fix merged. ----------------------------------------------------------------------------------- This email message is for the sole use of the intended recipient(s) and may contain confidential information. Any unauthorized review, use, disclosure or distribution is prohibited. If you are not the intended recipient, please contact the sender by reply email and destroy all copies of the original message. ----------------------------------------------------------------------------------- -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html