[PATCH 2/4] [NETDEV] cxgb3: rtnl_lock out of loop will be faster
Before this patch, it gets and releases the lock at each
iteration of the loop. Changing unregister_netdev to
unregister_netdevice and locking outside of the loop will
be faster for this approach.
Signed-off-by: Wang Chen <[EMAIL PROTECTED]>
---
cxgb3_main.c | 4 +++-
1 files changed, 3 insertions(+), 1 deletion(-)
--- linux-2.6.24.rc5.org/drivers/net/cxgb3/cxgb3_main.c 2007-12-12
10:19:39.000000000 +0800
+++ linux-2.6.24.rc5/drivers/net/cxgb3/cxgb3_main.c 2007-12-12
15:19:15.000000000 +0800
@@ -2584,9 +2584,11 @@ static void __devexit remove_one(struct
sysfs_remove_group(&adapter->port[0]->dev.kobj,
&cxgb3_attr_group);
+ rtnl_lock();
for_each_port(adapter, i)
if (test_bit(i, &adapter->registered_device_map))
- unregister_netdev(adapter->port[i]);
+ unregister_netdevice(adapter->port[i]);
+ rtnl_unlock();
if (is_offload(adapter)) {
cxgb3_adapter_unofld(adapter);
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
