From: Herbert Xu <[EMAIL PROTECTED]> Date: Tue, 11 Dec 2007 20:36:21 +0800
> David Miller <[EMAIL PROTECTED]> wrote: > > > > How can the NAPI_STATE_SCHED bit be cleared externally yet we take > > this list_move_tail() code path? > > His driver is probably buggy. When we had two drivers beginning > with e100 we often forgot to apply fixes to the both of them. Now > that we have three it's even more confusing. > > I just checked and indeed e1000e seems to be missing the NAPI fix > that was applied to e1000. Of course it doesn't rule out the > possibility of another NAPI bug in e1000. Thanks for checking. Indeed I stuck the huge comment there in net_rx_action() above the list move to try and explain things to people, so that if you saw a crash in the list manipulation, you're go check the driver first. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
