Herbert Xu wrote:
On Fri, Nov 30, 2007 at 02:35:43PM -0500, Andrew Gallatin wrote:
Isn't the value of 2 ethernet-specific (to round the 14-byte header up
to 16)? Given that the rest of the lro code is fairly careful to
calculate mac_hdr_len etc it seems as if it would be cleaner to make
this independent of the specific L2 being used.
(And I plan on using the LRO module for IP-over-InfiniBand so this is
not completely theoretical)
Good point!
We really should rename NET_IP_ALIGN so that both Ethernet and DMA
occur in it somehow :)
Good point. I tend to think all the world is ethernet.
Perhaps the better way would be to simply add an alignment pad
field to lro_mgr? When the driver initializes it, it specifies
any padding needed. Ethernet drivers would specify 2.
Just pass in the mac_hdr_len, and calculate the padding as
That was my first thought as well, but it turns out that
when lro_gen_skb() is called via the out1 label, mac_hdr_len
may not be known. It seemed simplest and cleanest to just
make it a field in lro_mgr.
Drew
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
