On Sun, 2 Dec 2007, Herbert Xu wrote: > On Sun, Dec 02, 2007 at 12:48:08AM +0200, Ilpo Järvinen wrote: > > > > This work was mostly done by David S. Miller. > > ... > > > @@ -253,6 +254,8 @@ struct sk_buff { > > struct sk_buff *next; > > struct sk_buff *prev; > > > > + struct rb_node rb; > > Did David really do this? :)
...Believe it or not, yes he did :-), and there's even a more convicing proof about that in here: http://marc.info/?l=linux-netdev&m=117269223013422&w=2 ...and in Dave's obsolete tcp-2.6 tree (which has the bug fixed version)... ;-) ...I changed it by just by moving tp->write_queue_rb = RB_ROOT to another function because I needed more initialization later on. > I suppose if we moved this into cb (by growing it by the required amount) > then at least the new space can be used by others. ...yeah, will do. -- i.