On Thu, Nov 29, 2007 at 06:08:30PM +0800, Wang Chen wrote:
> 
> Add a new UdpInEarlyDatagrams counter to count datagrams received early,
> but which might be dropped later.

Could you please split this into two patches? Have one do the
UdpInDatagrams change and the other to introduce the EarlyDatagrams
counter.

I'm a bit hesitant to introduce new counters in the MIB because
it'd be difficult if not impossible to ever remove them.  Do you
really need the early counter?

One more thing, please put the is_udplite clean-up in its own
patch too so it's absolutely clear what we're changing in the
patches that aren't clean-ups.

> Signed-off-by: Andi Kleen <[EMAIL PROTECTED]>
> Signed-off-by: Wang Chen <[EMAIL PROTECTED]>

Who's the author? Andi or you? Please make this obvious with a From
header when you resubmit.

Thanks,
-- 
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmV>HI~} <[EMAIL PROTECTED]>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to