Hi Eric,

> > +static struct sk_buff *alloc_gap_packet(struct Qdisc* sch, int size)
> > +{
> > +   struct sk_buff *skb;
> > +   struct net_device *dev = sch->dev;
> > +   unsigned char *pkt;
> > +   int pause_time = 0;
> > +   int pktsize = size + 2;
> > +
> > +   skb = alloc_skb(pktsize, GFP_ATOMIC);
> > +   if (!skb)
> > +           return NULL;
> > +
> > +   skb_reserve(skb, 2);
> 
> minor nit, but skb_reserve is not *needed* here.
> 
> skb_reserve() is used to align IP header on a 16 bytes boundary, and
> we do it on rx side to speedup IP stack, at the cost of a possibly more
> expensive DMA transfert.
> 
> Here you dont send an IP packet, do you ?
> 
Yes, I send not an IP packet but an Ethernet frame. I removed it
and confirmed to work. Thanks for your comment.

Best regards,
Ryousei Takano
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to