On Fri, 16 Nov 2007 01:12:43 -0800 (PST) David Miller <[EMAIL PROTECTED]> wrote:
> From: Eric Dumazet <[EMAIL PROTECTED]> > Date: Fri, 16 Nov 2007 09:59:03 +0100 > > > [PATCH] NET : NET_CLS_ROUTE : convert ip_rt_acct to per_cpu variables > > > > ip_rt_acct needs 4096 bytes per cpu to perform some accounting. > > It is actually allocated as a single huge array [4096*NR_CPUS] > > (rounded up to a power of two) > > > > Converting it to a per cpu variable is wanted to : > > - Save space on machines were num_possible_cpus() < NR_CPUS > > - Better NUMA placement (each cpu gets memory on its node) > > > > Signed-off-by: Eric Dumazet <[EMAIL PROTECTED]> > > This is better in one sense but worse in another. > > At least the previous code dynamically allocated the thing, > now at least one copy is taking up core kernel text image > space. Oh I see, you think that adding 4096 null bytes to the static percpu area might be a problem. > > I think it's an alloc_percpu() candidate, what do you think? > Yes absolutely, I will submit a new version. Thank you - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
