From: Chuck Lever <[EMAIL PROTECTED]> Date: Fri, 02 Nov 2007 15:14:26 -0400
> The (int) type cast in skb_truesize_check() is unneeded: without it, all > the variable types in the conditional expression are unsigned integers. As > it stands, the type cast causes a comparison between a signed and an > unsigned integer, which can produce unexpected results. > > Signed-off-by: Chuck Lever <[EMAIL PROTECTED]> This is checking for skb->truesize being decremented too much by other code, which could cause a wraparound below zero, so we do want negaitve checks here. Please stop these mindless signedness conversions without first trying to think about what the code might be trying to do. Thank you. - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
