On Tue, Oct 30, 2007 at 03:44:59AM -0400, Luis R. Rodriguez wrote: > On 10/29/07, Dale Farnsworth <[EMAIL PROTECTED]> wrote: > > On Mon, Oct 29, 2007 at 05:27:29PM -0400, Luis R. Rodriguez wrote: > > > This commit made an incorrect assumption: > > > -- > > > Author: Lennert Buytenhek <[EMAIL PROTECTED]> > > > Date: Fri Oct 19 04:10:10 2007 +0200 > > > > > > mv643xx_eth: Move ethernet register definitions into private header > > > > > > Move the mv643xx's ethernet-related register definitions from > > > include/linux/mv643xx.h into drivers/net/mv643xx_eth.h, since > > > they aren't of any use outside the ethernet driver. > > > > > > Signed-off-by: Lennert Buytenhek <[EMAIL PROTECTED]> > > > Acked-by: Tzachi Perelstein <[EMAIL PROTECTED]> > > > Signed-off-by: Dale Farnsworth <[EMAIL PROTECTED]> > > > -- > > > > > > arch/powerpc/platforms/chrp/pegasos_eth.c made use of a 3 defines there. > > > > > > [EMAIL PROTECTED]:~/devel/wireless-2.6$ git-describe > > > > > > v2.6.24-rc1-138-g0119130 > > > > > > This patch fixes this by internalizing 3 defines onto pegasos which are > > > simply no longer available elsewhere. Without this your compile will fail > > > > That compile failure was fixed in commit > > 30e69bf4cce16d4c2dcfd629a60fcd8e1aba9fee by Al Viro. > > > > However, as I examine that commit, I see that it defines offsets from > > the eth block in the chip, rather than the full chip registeri block > > as the Pegasos 2 code expects. So, I think it fixes the compile > > failure, but leaves the Pegasos 2 broken. > > > > Luis, do you have Pegasos 2 hardware? Can you (or anyone) verify that > > the following patch is needed for the Pegasos 2? > > Nope, sorry.
I am busy right now, but have various pegasos machines available for testing. What exactly should i test ? Friendly, Sven Luther - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
