On Sat, Oct 27, 2007 at 03:40:04PM -0700, Joe Perches wrote: > On Sat, 2007-10-27 at 23:47 +0400, Alexey Dobriyan wrote: > > Remove proc_fs.h from headers that doesn't really need it. > > > --- a/arch/powerpc/kernel/process.c > > +++ b/arch/powerpc/kernel/process.c > > @@ -17,6 +17,7 @@ > > #include <linux/errno.h> > > #include <linux/sched.h> > > #include <linux/kernel.h> > > +#include <linux/fs.h> > > Your code doesn't match your patch description. > > You've got new includes of: > > <linux/fs.h> > <linux/proc_fs.h> > <linux/err.h> > <linux/kref.h> > > and forward declarations of > > struct proc_dir_entry; > struct file_operations;
Removal of header A from header B creates compilation breakages for files which were getting A indirectly. So you have to complensate in all such cases. > As a general rule, I think it better to use includes > than use naked forward declarations. Well, we also want faster compilation and less time wasted when test-compiling patches. - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
