Laszlo Attila Toth wrote:
Interface groups let handle different interfaces together
especially in netfilter modules.
Modified net device structure and netlink interface.

@@ -891,6 +895,13 @@ static int do_setlink(struct net_device *dev, struct 
ifinfomsg *ifm,
                }
        }
+ if (tb[IFLA_IFGROUP]) {
+               write_lock_bh(&dev_base_lock);
+               dev->ifgroup = nla_get_u32(tb[IFLA_IFGROUP]);
+               write_unlock_bh(&dev_base_lock);
+               modified = 1;
+       }


The locking looks unnecessary, the rtnl should be enough.
I'm not even sure why its used for operstate and linkmode,
AFAICS they are also protected by the rtnl.
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to