On Thu, 11 Oct 2007 18:14:49 -0700 (PDT) David Miller <[EMAIL PROTECTED]> wrote:
> > Here is what I'm checking into net-2.6 for now: > > commit 6f535763165331bb91277d7519b507fed22034e5 > Author: David S. Miller <[EMAIL PROTECTED]> > Date: Thu Oct 11 18:08:29 2007 -0700 > > [NET]: Fix NAPI completion handling in some drivers. > > In order for the list handling in net_rx_action() to be > correct, drivers must follow certain rules as stated by > this comment in net_rx_action(): > > /* Drivers must not modify the NAPI state if they > * consume the entire weight. In such cases this code > * still "owns" the NAPI instance and therefore can > * move the instance around on the list at-will. > */ > > A few drivers do not do this because they mix the budget checks > with reading hardware state, resulting in crashes like the one > reported by [EMAIL PROTECTED] > > BNX2 and TG3 are taken care of here, SKY2 fix is from Stephen > Hemminger. > > Signed-off-by: David S. Miller <[EMAIL PROTECTED]> > Please use the version I just sent, it saves another non-cached read. - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
