On Thu, Oct 11, 2007 at 02:23:35AM -0600, Eric W. Biederman wrote: > > > So I would object to a patch that caused the RTNL_ASSERT to not > > warn about being called in an atomic context. > > ASSERT_RTNL does not warn about being called in an atomic context > today!
Well it did didn't it or we wouldn't be having this thread :) > Way way deep in mutex debugging on the slowpath there is a unreadable > and incomprehensible WARN_ON in muxtex_trylock that will trigger if > you have 10 tons of debugging turned on, and you are in, > interrupt context, and you manage to hit the slow path. I think that > is a pretty unlikely scenario. Well thanks to that warning we're on our way of improving the code that triggered it in such a way that this warning will soon go silent. That's precisely the reason why I object to having this warning removed. Now you have a good point that this warning doesn't trigger all the time. The fix to that is to *make* it trigger always, not removing it. Thanks, -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmV>HI~} <[EMAIL PROTECTED]> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
