J Hadi Salim <[EMAIL PROTECTED]> wrote on 10/08/2007 07:35:20 PM: > I dont see something from Krishna's approach that i can take and reuse. > This maybe because my old approaches have evolved from the same path. > There is a long list but as a sample: i used to do a lot more work while > holding the queue lock which i have now moved post queue lock; i dont > have any speacial interfaces/tricks just for batching, i provide hints > to the core of how much the driver can take etc etc. I have offered > Krishna co-authorship if he makes the IPOIB driver to work on my > patches, that offer still stands if he chooses to take it.
My feeling is that since the approaches are very different, it would be a good idea to test the two for performance. Do you mind me doing that? Ofcourse others and/or you are more than welcome to do the same. I had sent a note to you yesterday about this, please let me know either way. ******************* Previous mail ****************** Hi Jamal, If you don't mind, I am trying to run your approach vs mine to get some results for comparison. For starters, I am having issues with iperf when using your infrastructure code with my IPoIB driver - about 100MB is sent and then everything stops for some reason. The changes in the IPoIB driver that I made to support batching is to set BTX, set xmit_win, and dynamically reduce xmit_win on every xmit and increase xmit_win on every xmit completion. Is there anything else that is required from the driver? thanks, - KK - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html