On Sun, 07 Oct 2007 23:59:56 -0700 (PDT)
David Miller <[EMAIL PROTECTED]> wrote:

> From: Stephen Hemminger <[EMAIL PROTECTED]>
> Date: Fri, 5 Oct 2007 17:14:07 -0700
> 
> > Fix a bunch of sparse warnings. Mostly about 0 used as
> > NULL pointer, and shadowed variable declarations.
> > 
> > The two noteable changes are:
> >  * hash size should have been unsigned
> >  * cls_u32 had a case where error code wasn't been
> >    propogated properly, so it could return 0 but still
> >    have an error.
> > 
> > Signed-off-by: Stephen Hemminger <[EMAIL PROTECTED]>
> 
> Applied, and I stuffed the cls_u32 fix into net-2.6 as well.
> 
> But please fix the following, this is the second time I've
> had to remove this bit from one of your patches.
> 
> > @@ -6,7 +6,7 @@
> >   *
> >   * Alexey Kuznetsov  <[EMAIL PROTECTED]>
> >   * Ben Greear <[EMAIL PROTECTED]>
> > - * Jens Låås <[EMAIL PROTECTED]>
> > + * Jens Låås <[EMAIL PROTECTED]>
> >   *
> >   * This program is free software; you can redistribute it and/or
> >   * modify it under the terms of the GNU General Public License
> 
> Please please please please, for the second time, fix the encoding
> your editor uses when you save copies of this source file, this hunk
> of your patches never applies cleanly.
> 

It's either an Emacs or quilt problem. Probably emacs.

-- 
Stephen Hemminger <[EMAIL PROTECTED]>
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to