On Tue, 02 Oct 2007 23:02:53 +0200 Oliver Hartkopp <[EMAIL PROTECTED]> wrote:
> Arnaldo Carvalho de Melo wrote: > > Em Tue, Oct 02, 2007 at 03:10:11PM +0200, Urs Thuermann escreveu: > > > >> + > >> +#ifdef CONFIG_CAN_DEBUG_DEVICES > >> +static int debug; > >> +module_param(debug, int, S_IRUGO); > >> +#endif > >> > > > > Can debug be a boolean? Like its counterpart on DCCP: > > > > net/dccp/proto.c: > > > > module_param(dccp_debug, bool, 0444); > > > > 'debug' should remain an integer to be able to specifiy debug-levels or > bit-fields for different Debug outputs. > > > Where we also use a namespace prefix, for those of us who use ctags or > > cscope. > > > > Even if i don't have any general objections to rename this 'debug' to > 'vcan_debug', it looks like an 'overnamed' module parameter for me. Is > this a genereal naming scheme recommendation for debug module_params? > Please consider using netif_msg_xxx() and module parameter to set default message level, like other real network drivers already do. -- Stephen Hemminger <[EMAIL PROTECTED]> - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
