Evgeniy Polyakov wrote: > On Fri, Sep 28, 2007 at 10:41:31PM +0900, Satoshi OSHIMA ([EMAIL PROTECTED]) wrote: >> This patch introduces memory usage measurement for UDP. >> >> These 3 points were updated. >> >> - UDP specific codes in IP layer were removed. >> >> - atomic_sub() in a loop was removed >> >> - accounting during socket destruction > > Another approach is to account only at the highest UDP layer and having > datagram skb destructor just like it is done in TCP, but this approach > is also resonable.
This patch set try to introduce a memory accounting by the page because TCP does. And ip_append_data() merges payloads to a sk_buff if previous sk_buff has enough space. The problem is that udp_append_data() doesn't recognize whether this merge happens or not. If the accounting must be in UDP layer, we need to change the interface of ip_append_data() to know this merge happens. Once the interface is changed, we have to maintain other protocol stacks to keep up with the change. But I didn't want to do it to keep this patch set small in the first step. > I already told that patches 1 and 3 have broken indent, please fix that. Oops! I will fix that. > A hint: when you are about to submit something network related for inclusion, > and strongly believes it is ready, it can be a not that bad idea to add > David Miller <[EMAIL PROTECTED]> to copy list, he can complain about > backlog and so on, but will read you mail twice :) but do not tell anyone. Thank you for your advice. I will do that! Satoshi Oshima - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
