From: Varun Chandramohan <[EMAIL PROTECTED]> Date: Thu, 20 Sep 2007 20:57:51 +0530
> @@ -420,6 +421,7 @@ static int fn_hash_insert(struct fib_tab > else > fa = fib_find_alias(&f->fn_alias, tos, fi->fib_priority); > > + do_gettimeofday(&tv); > /* Now fa, if non-NULL, points to the first fib alias > * with the same keys [prefix,tos,priority], if such key already > * exists or to the node before which we will insert new one. gettimeofday() is expensive, we don't even use it to timestamp every incoming packet and we therefore should not do it every route cache entry we create in order to handle DoS situations efficiently I honestly don't like these patches. I literally cringe every time you post a new revision. It's either going to add new costs to route management or be so inaccurate as to be useless. I question it's usefulness even if implemented efficiently and accurately. I really don't see people lining up asking for a route aging metric. We could report zero and be compliant with the RFC, we don't age our route entries like the model of the SNMP vars seems to suggest, so it's honestly accurate. And this would mean no kernel changes, as the userland program could just report zero in the absense of a kernel provided value. - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
