Hi Andrew, Thanks for picking up the patch.
On 9/28/07, Andrew Morton <[EMAIL PROTECTED]> wrote: > On Thu, 27 Sep 2007 19:51:19 +0900 > Magnus Damm <[EMAIL PROTECTED]> wrote: > > > ax88796: add 93cx6 eeprom support > > > > This patch hooks up the 93cx6 eeprom code to the ax88796 driver and modifies > > the ax88796 driver to read out the mac address from the eeprom. We need > > this for the ax88796 on certain SuperH boards. The pin configuration used > > to connect the eeprom to the ax88796 on these boards is the same as pointed > > out by the ax88796 datasheet, so we can probably reuse this code for > > multiple > > platforms in the future. > > I'm showing a minor reject between this and Francois's git-r8169.patch. [snip] Oh, sorry about that. I should have built the patch on top of -mm instead. > You both made the same change to eeprom_93cx6.h. That all sounds good but > it would be comforting if you could review each other's work, please... I thought I was more or less the only user, but thanks for pointing that out. The eeprom code in the r8169 driver from 2.6.23-rc8-mm2/git-r8169.patch looks fine, but I don't understand the point of adding the size member to the eeprom struct in eeprom_93cx6.h. Especially since no code change is made in eeprom_93cx6.c. Thanks, / magnus - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
