On Thu, 27 Sep 2007 09:14:11 +0100 Jochen Voß <[EMAIL PROTECTED]> wrote:
> Hi Stephen, > > On 27 Sep 2007, at 01:58, Stephen Hemminger wrote: > > + /* This chip has hardware problems that generates bogus status. > > + * So do only marginal checking and expect higher level protocols > > + * to handle crap frames. > > + */ > > + if (sky2->hw->chip_id == CHIP_ID_YUKON_FE_P && > > + sky2->hw->chip_rev == CHIP_REV_YU_FE2_A0 && > > + length != count) > > + goto okay; > > Shouldn't the condition be "length == count"? > No, the code is correct as is. Basically if length == count, then the status field is correct, and the driver can go ahead and use it. If length != count, then the status is bogus but the data is okay. -- Stephen Hemminger <[EMAIL PROTECTED]> - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
