David Miller wrote:
From: Jeff Garzik <[EMAIL PROTECTED]>
Date: Wed, 19 Sep 2007 18:05:25 -0400
That said, the 2-arg macro arg order is wrong. It should be (reg,val)
like tg3 and other drivers.
I actually wanted to mirror the ordering that
writel() uses.
So the choice is arbitrary, either be consistent with
our well established asm/io.h interfaces or a bunch
of network driver :-)
IMO (val,reg) was always unnatural. From looking at the register
read/write interfaces people continually reinvent, humans definitely
lean towards (reg,val).
Jeff
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
