Alexey Kuznetsov wrote:
> Hello!
>
>>CCed Alexey just to be safe, but I think the patch should be fine.
>
>
> Yes. But what'a about limit == 1? tc prohibits this case, but it is still
> not nice to have the bug in kernel. Plus, code remains creepy, the check
>
> + if (++sch->q.qlen < q->limit) {
>
> still looks as a scary off-by-one. I would go all the way: replace this
> with natural:
>
> if (++sch->q.qlen <= q->limit) {
>
> and maxed q->limit at SFQ_DEPTH-2. Patch enclosed.
Thats even better, thanks :)
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
