Looks fine overall, with one minor nitpick: > - if (unlikely(memcmp(&neigh->dgid.raw, > + if (unlikely((memcmp(&neigh->dgid.raw, > skb->dst->neighbour->ha + 4, > - sizeof(union ib_gid)))) { > + sizeof(union ib_gid))) || > + (neigh->dev != dev))) {
the indentation here makes this confusing to read -- I would just do: } else if (neigh->ah) { if (unlikely(memcmp(&neigh->dgid.raw, skb->dst->neighbour->ha + 4, - sizeof(union ib_gid)))) { + sizeof(union ib_gid)) || + neigh->dev != dev)) { - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html